fix(vertex_ai): accept encoding_format param for Gemini/Vertex AI embeddings. #17239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eddings
The OpenAI Python client (v1.x) automatically sends encoding_format: base64
in embedding requests. This was causing UnsupportedParamsError for Gemini
embeddings because encoding_format was not in the list of supported params.
This fix adds encoding_format to the supported params list for Vertex AI
embeddings. The parameter is accepted but not passed to the Gemini API
since Gemini doesn't support it.
Fixes the issue where users get:
litellm.UnsupportedParamsError: gemini does not support parameters: {'encoding_format': 'base64'}
Affected models:
- gemini/text-embedding-004
- gemini/gemini-embedding-001
- vertex_ai/textembedding-gecko
- vertex_ai/text-embedding-005
- All other Vertex AI embedding models
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OpenAI Python client (v1.x) automatically sends encoding_format: base64 in embedding requests. This was causing UnsupportedParamsError for Gemini embeddings because encoding_format was not in the list of supported params.
This fix adds encoding_format to the supported params list for Vertex AI embeddings. The parameter is accepted but not passed to the Gemini API since Gemini doesn't support it.
Fixes the issue where users get:
litellm.UnsupportedParamsError: gemini does not support parameters: {'encoding_format': 'base64'}
Affected models: